[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20637: incompatible, undocumented change to vc-working-revision
From: |
Michael Albinus |
Subject: |
bug#20637: incompatible, undocumented change to vc-working-revision |
Date: |
Tue, 29 Mar 2016 20:13:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
Hi Dmitry
> Also, reverting this commit also seems to uncover tests that shouldn't
> pass anyway. Checks like
>
> (should (eq (vc-state default-directory)
> (vc-state default-directory backend)))
>
> don't verify much, and in this case they seem to verify the wrong
> thing. More on that in the respective threads in emacs-devel later.
>
> Michael, thoughts?
Why is verifying such tests "the wrong thing"? It's a while ago that I
wrote the tests, but IIRC I've added them exactly because I did expect
that such tests should pass, and they didn't. I even fixed some trivial
corner cases when writing the tests. as far as I understood the code.
Best regards, Michael.