[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23785: Emacs 25: "Undo" overdoes things.
From: |
Óscar Fuentes |
Subject: |
bug#23785: Emacs 25: "Undo" overdoes things. |
Date: |
Fri, 17 Jun 2016 23:49:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) |
Alan Mackenzie <acm@muc.de> writes:
> I don't think it's all that minor an issue. `undo' can no longer be
> depended upon to restore a buffer to its unchanged state.
>
> I've suffered several similar annoyances with `undo' in the emacs-25
> branch.
Me too, although I'm not sure about Emacs being the culprit. I use Evil
and it adds some heuristics on top of Emacs'.
> Each buffer changing command is meant to have its own undo boundary
> (with the exception of self-insert-command and the single character
> deleting command).
>
> And having to undo/redo command sequences by hand is _very_ irritating
> when testing.
Only when testing? :-)
I've observed cases where sequences of char inserts were undone one at a
time and cases where entire edit sessions across multiple areas of the
file vanished with one `undo'.
> I think there's a case to be made for fixing this bug for Emacs 25.1.
FWIW, this is the change that enabled keeping the undo log after
revert-buffer (a feature I asked for, BTW):
commit 22513e526eba97bd1014e4bacde0a8649fbe7870
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Tue May 28 21:07:53 2013 -0400
* src/fileio.c (Finsert_file_contents): Preserve undo info when reverting
a buffer.
Fixes: debbugs:8447
- bug#23785: Emacs 25: 'Undo' overdoes things., (continued)
- bug#23785: Emacs 25: 'Undo' overdoes things., Stefan Monnier, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: "Undo" overdoes things., Phillip Lord, 2016/06/17
- bug#23785: Emacs 25: "Undo" overdoes things., Alan Mackenzie, 2016/06/18
- bug#23785: Emacs 25: "Undo" overdoes things.,
Óscar Fuentes <=
- bug#23785: Emacs 25: "Undo" overdoes things., Phillip Lord, 2016/06/20