[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23785: Emacs 25: 'Undo' overdoes things.
From: |
Phillip Lord |
Subject: |
bug#23785: Emacs 25: 'Undo' overdoes things. |
Date: |
Tue, 21 Jun 2016 15:29:47 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: phillip.lord@russet.org.uk (Phillip Lord)
>> Cc: "Eli Zaretskii" <eliz@gnu.org>, acm@muc.de, 23785@debbugs.gnu.org
>> Date: Mon, 20 Jun 2016 16:03:35 +0100
>>
>> My suggestion: this patch goes to Emacs-25. And the previous patch
>> (which automatically adds an undo boundary to current-buffer regardless
>> of changes), goes to master.
>
> So can you please show the "previous" patch? There were too many of
> them.
This one, to master.
>From 2ab1f314ad6fe0e68420cc510445495467d82b8f Mon Sep 17 00:00:00 2001
From: Phillip Lord <phillip.lord@russet.org.uk>
Date: Fri, 17 Jun 2016 22:34:50 +0100
Subject: [PATCH] Fix missing undo-boundary after revert-buffer
* lisp/simple.el (undo-auto--boundaries): Ensure an undo-boundary after
every command whether it (apparently) changes the buffer or not.
Addresses Bug#23785
---
lisp/simple.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lisp/simple.el b/lisp/simple.el
index b66827d..3110430 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -2875,6 +2875,10 @@ undo-auto--boundaries
"Check recently changed buffers and add a boundary if necessary.
REASON describes the reason that the boundary is being added; see
`undo-last-boundary' for more information."
+ ;; (Bug #23785) All commands should ensure that there is an undo
+ ;; boundary whether they have changed the current buffer or not.
+ (when (eq cause 'command)
+ (add-to-list 'undo-auto--undoably-changed-buffers (current-buffer)))
(dolist (b undo-auto--undoably-changed-buffers)
(when (buffer-live-p b)
(with-current-buffer b
--
2.8.4
- bug#23785: Emacs 25: 'Undo' overdoes things., (continued)
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/20
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Stefan Monnier, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Phillip Lord, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: 'Undo' overdoes things.,
Phillip Lord <=
- bug#23785: Emacs 25: 'Undo' overdoes things., Eli Zaretskii, 2016/06/21
- bug#23785: Emacs 25: "Undo" overdoes things., Phillip Lord, 2016/06/17
- bug#23785: Emacs 25: "Undo" overdoes things., Alan Mackenzie, 2016/06/18
- bug#23785: Emacs 25: "Undo" overdoes things., Óscar Fuentes, 2016/06/17
- bug#23785: Emacs 25: "Undo" overdoes things., Phillip Lord, 2016/06/20