bug#24753: 26.0.50; Error using Edebug on code that uses cl-defmethod

[Gemini Lasswell]

Edebug gets confused after instrumenting multiple methods with the same
name created by cl-defgeneric and cl-defmethod. To reproduce, save the
following bit of code (which is an excerpt from cl-generic-tests.el)
to bug.el:

(require 'cl-generic)

(fmakunbound 'foo)
(cl-defgeneric foo (x y))
(cl-defgeneric (setf foo) (v y z) "My generic doc.")
(cl-defmethod (setf foo) (v (y t) z) (list v y z))
(cl-defmethod (setf foo) (v (_y (eql 4)) z) (list v "four!" z))

(defun foo-bug ()
  (message "%s" (setf (foo 'a 'b) 'v)))

(foo-bug)

Steps to reproduce:
1. emacs -Q
2. C-x C-f bug.el RET
3. M-x edebug-all-defs RET
4. M-x eval-buffer RET
5. g

Result: edebug--display: Args out of range: [44 51 61 62], 4

The trouble seems to be that Edebug is attaching its per-definition data
for both methods to the same symbol, setf@foo. I found that
changing the relevant line in cl-defmethod's Edebug spec from this:

             [&or name ("setf" :name setf name)]

to this:

             [&or symbolp ("setf" symbolp)]

makes the problem go away by creating new anonymous symbols for the
methods. Although if you want to try this out interactively, you'll need
to set edebug-form-data to nil for the buffer, because otherwise Edebug
will remember the previous name you gave the definition and reuse it.

While I was looking at the Edebug spec for cl-defmethod, I also noticed
that it uses list to match the argument list. Edebug is going to treat
list as a predicate, and list is going to return a non-nil value for
whatever is in that match position. I don't know of any real problem
that could cause, but using listp would be more correct.


In GNU Emacs 26.0.50.4 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 
10.11.6 (Build 15G1004))
 of 2016-10-20 built on rainbow.local
Repository revision: 9e1e257ea8605354d15b4bd93e0af6188aae40db
Windowing system distributor 'Apple', version 10.3.1404
Recent messages:
Mark set
Replaced 8 occurrences
Quit
nil
Edebug: setf@foo [2 times]
Edebug: foo-bug
Go...
edebug--display: Args out of range: [44 51 61 62], 4
Configured using:
 'configure --with-ns --disable-ns-self-contained'

Configured features:
JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS
NS

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  global-undo-tree-mode: t
  undo-tree-mode: t
  diff-auto-refine-mode: t
  ivy-mode: t
  buffer-face-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  pyvenv-mode: t
  shell-dirtrack-mode: t
  nameless-mode: t
  beacon-mode: t
  rainbow-mode: t
  column-enforce-mode: t
  volatile-highlights-mode: t
  region-state-mode: t
  ws-butler-global-mode: t
  ws-butler-mode: t
  show-smartparens-global-mode: t
  show-smartparens-mode: t
  smartparens-global-mode: t
  smartparens-global-strict-mode: t
  smartparens-strict-mode: t
  smartparens-mode: t
  which-key-mode: t
  modalka-mode: t
  recentf-mode: t
  global-auto-revert-mode: t
  winner-mode: t
  display-time-mode: t
  savehist-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow emacsbug cl-generic-tests testcover flow-fill jka-compr shr svg
dom browse-url qp nndraft nnmh nnfolder utf-7 epa-file sort smiley
gnus-cite mail-extr gnus-async gnus-bcklg gnus-agent gnus-srvr
gnus-score score-mode nnvirtual nntp gnus-ml gnus-msg disp-table nndoc
gnus-cache gnus-dup gnus-art mm-uu mml2015 mm-view mml-smime smime dig
gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail
mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range
gnus-win gnus nnheader mm-archive message rfc822 mml mml-sec epa derived
epg gnus-util rmail rmail-loaddefs mailabbrev gmm-utils mailheader crm
debbugs-gnu add-log zoom-window highlight-symbol undo-tree diff
eieio-opt speedbar sb-image ezimage dframe tabify shrink-whitespace
dash-at-point visual-regexp expand-region text-mode-expansions
python-el-fgallina-expansions er-basic-expansions expand-region-core
expand-region-custom ielm comment-dwim-2 ert find-func ewoc debug pp
edebug vc-git diff-mode colir flx dired dired-loaddefs counsel esh-util
swiper ivy delsel ffap face-remap guess-style smtpmail sendmail
mail-utils yasnippet highlight-indentation flymake company help-fns
radix-tree elpy pyvenv elpy-refactor smartparens-python python tramp-sh
tramp tramp-compat tramp-loaddefs trampver shell pcomplete format-spec
json map grep compile files-x cus-edit virtualenvwrapper gud comint
nameless lisp-mnt ace-window avy beacon smex ido deft debbugs
soap-client mm-decode mm-bodies mm-encode warnings rng-xsd rng-dt
rng-util xsd-regexp xml rainbow-mode ansi-color color s hydra lv
column-enforce-mode etags xref project volatile-highlights region-state
ws-butler smartparens-config smartparens thingatpt dash which-key
modalka quail smart-mode-line-dark-theme smart-mode-line advice
rich-minority whiteboard-theme classic-theme recentf tree-widget
wid-edit autorevert filenotify winner ring time cus-start cus-load
savehist cap-words superword subword use-package diminish bind-key
easy-mmode finder-inf edmacro kmacro info network-stream starttls
url-http tls gnutls mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr url-gw nsm subr-x puny url-cache url-auth url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util mailcap cl package epg-config url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache url-vars seq byte-opt gv bytecomp byte-compile cl-extra
help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev
obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face
macroexp files text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote kqueue
cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 1177625 172614)
 (symbols 48 51408 177)
 (miscs 40 3885 2827)
 (strings 32 171089 94705)
 (string-bytes 1 4748760)
 (vectors 16 79548)
 (vector-slots 8 1384454 66001)
 (floats 8 5239 1496)
 (intervals 56 62071 8434)
 (buffers 976 47))