bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26973: 26.0.50; sleep-for behavior changes with global-auto-revert-m


From: Paul Eggert
Subject: bug#26973: 26.0.50; sleep-for behavior changes with global-auto-revert-mode enabled
Date: Sat, 27 May 2017 11:19:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1

Andreas Politz wrote:

I think your patches are against an older revision.

OK, I rebased the patches to master and installed them there (after adjusting to the comments below) so you shouldn't have to worry about version mismatch.

[...] a later call to inotify-add-watch that lacks IN_OPEN will
disable an already-existing watch that specifies IN_OPEN, right? [...]

I don't think so. It means that no one can watch for open/close/access
events

Oh, right. I fixed the commit message accordingly.

[...] The second patch restores onlydir (it appears to have been
removed by mistake).

See above, I guess.

Yeah, I checked the GNU/Linux source code, and it is a flag that affects only the inotify_add_watch call itself, not the watch descriptor, so we don't need to worry about it colliding with other watches.

The third patch uses IN_MASK_ADD instead of a promiscuous mask.

We could do that.

Thanks, it's now done as part of the installed patches. I verified that the originally-reported bug is still fixed in master, and am marking the bug as done.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]