bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23568: 25.0.94; Mode line menus appear incorrectly in some monitor c


From: Alex
Subject: bug#23568: 25.0.94; Mode line menus appear incorrectly in some monitor configurations
Date: Fri, 02 Jun 2017 18:54:03 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

martin rudalics <address@hidden> writes:

>> In the end, we would still leave the function interface so that users
>> can still call the discussed procedures from lisp code, right?
>
> I think so, yes.
>
>> (defun display-monitor-attribute (attribute &optional frame x y)
>>   "Return the value of the attribute of the 'current' monitor.
>> By default, use the frame info to determine the current monitor,
>> but if x and y are non-nil then use the given coordinates to
>> determine it."
>>   (if (and x y)
>
> Probably, FRAME should be replaced by DISPLAY as in other ‘display-...’
> functions.  X and Y must be checked properly to avoid throwing an error
> when they are used in the arithmetics.  And the doc-string should
> explicitly state that the first argument is ignored when X and Y are
> both non-nil.

I fixed up the docstrings to match display-monitor-attributes-list.

Don't you want to throw an error when x and y are used, but are not
integers?

Also, should yet another procedure be created that abstracts out adding
the min_{x,y} and width/height components of the geometry/workarea
attributes, or should it be expected for each caller to do that
manually?

The current diff is attached below:

Attachment: multi-headv3.diff
Description: multi-headv3


reply via email to

[Prev in Thread] Current Thread [Next in Thread]