bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc


From: npostavs
Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc.
Date: Wed, 14 Jun 2017 20:05:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

Thierry Volpiatto <address@hidden> writes:

> Johan Bockgård <address@hidden> writes:
>
>> Thierry Volpiatto <address@hidden> writes:
>>
>>> Fix eldoc with positional arg among keyword args.
>>>
>>> * lisp/progmodes/elisp-mode.el (elisp--highlight-function-argument):
>>> Switch to indexed arg searching when no keyword found behind arg.
>>
>> This code is wrong both with and without your fix. All mandatory and
>> optional arguments should be used *before* keywords are matched.
>>
>> Given this definition of `foo',
>>
>>     (cl-defun foo (x &key a b c)
>>       (list x a b c))
>>
>> `:b' in the following call specifies the positional argument `x', not
>> the keyword argument `b':
>>
>>     (foo :b :a 1)  =>  (:b 1 nil nil)
>
> Fixed as well.

Do you mean you have an updated patch that fixes this as well (which you
seem to have forgotten to post)?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]