bug#27986: 26.0.50; 'rename-file' can rename files without confirmation

[Ken Brown]

On 8/16/2017 3:33 PM, Ken Brown wrote:
> On 8/14/2017 7:03 PM, Paul Eggert wrote
> > Now that renameat_noreplace works on DOS_NT, would it make sense to 
> > apply the attached further patch as well? If we can get 
> > renameat_noreplace to work on Cygwin the we could simplify the 
> > fileio.c code even further.
>
> I'm in the process of writing an implementation of something like 
> 'renameat2', which I'll submit to the Cygwin developers.

This is now done.  The implementation will appear in the next Cygwin 
release.  When that release occurs, I'll install something like the 
attached patch.

Question: Is the patch OK as is, or should I make the call to renameat2 
conditional on CYGWIN?  In other words, is it safe to assume that 
renameat2 is defined on any platform on which RENAME_NOREPLACE is 
defined but not SYS_renameat2?

Ken

0001-Implement-renameat_noreplace-on-recent-Cygwin.patch
Description: Text document