[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-render
From: |
Lars Ingebrigtsen |
Subject: |
bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions |
Date: |
Thu, 05 Oct 2017 13:18:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> - (cond (external
>> - (funcall external dom))
>> - ((fboundp function)
>> - (funcall function dom))
>> - (t
>> - (shr-generic dom)))
>> + (shr-indirect-call tag-name dom)
[...]
> Wouldn't reverting it make the entire change rather pointless?
No, the other calls to shr-indirect are fine, and was what was missing.
> If the issue is with stack usage, we could increase the stack when
> shr-descend is called. As for speed, the old code had such an
> indirection as well, albeit via funcall, no?
The old call calls virtually always ends up with
(funcall function dom)
The new code calls shr-indirect-call which will will then
(funcall function dom)
So one extra function call for each node.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions,
Lars Ingebrigtsen <=
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Vasilij Schneidermann, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Lars Ingebrigtsen, 2017/10/05
- bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions, Eli Zaretskii, 2017/10/06