[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’
From: |
Mark Oteiza |
Subject: |
bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’ |
Date: |
Sat, 14 Oct 2017 17:24:59 -0400 |
User-agent: |
NeoMutt/20171006-14-e64a43 |
On 13/10/17 at 05:33pm, Eli Zaretskii wrote:
> > From: Davor Rotim <rotim.davor@gmail.com>
> > Date: Fri, 13 Oct 2017 15:33:24 +0200
> >
> > Started with emacs -Q, opened a dired buffer, navigated to an image and
> > pressed C-t .
> > on it (image-dired-display-thumb) to generate a thumbnail. That leaves me
> > with only an error message:
> >
> > Error running timer ‘image-dired-thumb-queue-run’: (range-error "floor"
> > 1505334534.0059688)
>
> Mark, could you please look at this? You changed the code to use
> floor instead of rounding via format "%.0f", but floor returns an
> Emacs integer which can overflow on 32-bit hosts for large time
> values, as happens here. I think we should use ffloor instead, and if
> that produces a decimal point, eliminate it with "%.0f" format.
What you propose sounds fine to me.