bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28831: 27.0.50; debbugs: funny address in To field


From: Noam Postavsky
Subject: bug#28831: 27.0.50; debbugs: funny address in To field
Date: Fri, 20 Oct 2017 08:55:52 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Noam Postavsky <npostavs@users.sourceforge.net> writes:
>
>> -                    (replace-regexp-in-string "^http://"; "" mbox-url)))))
>> +                    (replace-regexp-in-string "^https://"; "" mbox-url)))))
>
> Perhaps that should be
>
>> +                    (replace-regexp-in-string "^https?://" "" mbox-url)))))

Or maybe we could use url-parse?  Seems a bit neater.

>From 992b5b8a33eab5ea0afa020030408f76dcfd4330 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Thu, 19 Oct 2017 20:07:05 -0400
Subject: [PATCH v2] Handle https url for debbugs mbox (Bug#28831)

In 2017-09-13 "Prefer HTTPS to FTP and HTTP in documentation",
gnus-bug-group-download-format-alist was updated to use https for the
debbugs.gnu.org mbox links, but gnus-read-ephemeral-bug-group assumed
http links.
* lisp/gnus/gnus-group.el (gnus-read-ephemeral-bug-group): Use
url-parse functions to get the host name, instead of ad-hoc regexps.
---
 lisp/gnus/gnus-group.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 985efe6272..4a41c49590 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -2467,9 +2467,7 @@ gnus-read-ephemeral-bug-group
        ;; Add the debbugs address so that we can respond to reports easily.
        (let ((address
               (format "%s@%s" (car ids)
-                      (replace-regexp-in-string
-                       "/.*$" ""
-                       (replace-regexp-in-string "^http://"; "" mbox-url)))))
+                       (url-host (url-generic-parse-url mbox-url)))))
          (goto-char (point-min))
          (while (re-search-forward (concat "^" message-unix-mail-delimiter)
                                    nil t)
-- 
2.11.0


reply via email to

[Prev in Thread] Current Thread [Next in Thread]