bug#30063: 26.0.90; Silent fail with `rst-compile-pdf-preview'

[Glenn Morris]

Noam Postavsky wrote:

> Simen Heggestøyl <simenheg@gmail.com> writes:
>
>>       (command (format "%s %s %s && %s %s ; rm %s"
>> +                      pdf-compile-program
>>                        buffer-file-name tmp-filename
>>                        rst-pdf-program tmp-filename tmp-filename)))
>> +    (unless (executable-find pdf-compile-program)
>> +      (error "Cannot find executable `%s'" pdf-compile-program))
>> +    (unless (executable-find rst-pdf-program)
>> +      (error "Cannot find executable `%s'" rst-pdf-program))
>
> It's possible to have PATH and exec-path desynchronized, such that the
> above code could throw an error even though the
> start-process-shell-command call later would succeed.  Maybe we should
> should just consider that a misconfiguration on the user's part though.

Yes, I think PATH != exec-path is a user error.

BTW what happens with the above if the program is present, but fails for
some reason? Is nothing still shown to the user in that case?

Also, does it actually need to go through the shell?