[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for
From: |
Eli Zaretskii |
Subject: |
bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames |
Date: |
Wed, 31 Jan 2018 18:02:06 +0200 |
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, 30243@debbugs.gnu.org,
> michael.albinus@gmx.de
> Date: Tue, 30 Jan 2018 19:01:52 -0500
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > If my git bisect is correct, it was
> > commit a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix Bug#29579. So
> > by fixing one bug we introduced another one :(
>
> Actually, looking at Bug#29579 again, it doesn't seem *that* bad, and as
> far as I can tell, it has existed for a long time (still occurs back in
> 24.3). So reverting that fix seems like a reasonable option too. I can
> confirm that doing so fixes this bug.
I tend to agree. Michael, WDYT?
> > I also wonder how come we've succeeded to break quoted file names
> > so fundamentally -- what change did that, and why did we make it
> > on the release branch?
>
> IMO, the root cause is pretty clearly lack of adequate tests for this.
> There are more than 60 file-handler operations; it's crazy to expect to
> be able to make a correct change without an automated test that at least
> exercises each one.
Right, thanks.
So if Michael agrees, I think we should revert the fix for bug#29579
on the release branch, and merge the branch you two worked on onto
master.
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, (continued)
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Noam Postavsky, 2018/01/25
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Michael Albinus, 2018/01/26
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Noam Postavsky, 2018/01/26
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Michael Albinus, 2018/01/28
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Noam Postavsky, 2018/01/28
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Michael Albinus, 2018/01/28
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Eli Zaretskii, 2018/01/30
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Michael Albinus, 2018/01/30
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Philipp Stephani, 2018/01/30
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Noam Postavsky, 2018/01/30
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames,
Eli Zaretskii <=
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Michael Albinus, 2018/01/31
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Noam Postavsky, 2018/01/31
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Michael Albinus, 2018/01/31
- bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames, Eli Zaretskii, 2018/01/31