bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error no


From: Basil L. Contovounesios
Subject: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list
Date: Sun, 18 Mar 2018 00:14:13 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Attachment: 0001-Pass-json-readtable-error-data-as-a-list-bug-30489.patch
Description: Text Data

Noam Postavsky <address@hidden> writes:

> "Basil L. Contovounesios" <address@hidden> writes:
>
>> @@ -685,7 +685,7 @@ json-readtable-dispatch
>>        (push (list c 'json-read-number) table))
>>      (pcase-dolist (`(,c . ,rest) table)
>>        (push `((eq ,char ,c) (,@rest)) res))
>> -    `(cond ,@res (t (signal 'json-readtable-error ,char)))))
>> +    `(cond ,@res (t (signal 'json-readtable-error ,(list char))))))
>
> Actually, shouldn't this be (list ,char)?
>
> Otherwise, I get this warning when compiling:
>
> In end of data:
> ../../lisp/json.el:766:1:Warning: the function ‘char’ is not known to be
>     defined.

Right you are; thanks for catching this embarrassing macro mistake.

I attach an updated patch including your fix and the bug number.

Thanks again,

-- 
Basil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]