bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30905: Add tests for buffer-base-buffer function


From: Noam Postavsky
Subject: bug#30905: Add tests for buffer-base-buffer function
Date: Sun, 25 Mar 2018 07:42:04 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)

severity 30905 wishlist
quit

Shanavas <address@hidden> writes:
>
> This is my first contribution to emacs. Is this patch ready to go or Am I 
> missing something??

A couple of things.

Have assigned copyright for Emacs? (the change is small enough to
install regardless, but note that we only accept up to 15 lines worth of
unassigned code per person).

> Subject: [PATCH] Add tests for buffer-base-buffer function
>
> ---

You should add a ChangeLog style entry to the commit message, as
described in CONTRIBUTE.
  
> +(ert-deftest test-buffer-base-buffer-indirect ()
> +  (let* ((base (get-buffer-create "base")

You should rather use with-temp-buffer, so that the test will not
interfere with anything else (same for the second test).





reply via email to

[Prev in Thread] Current Thread [Next in Thread]