bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#31006: [PATCH] Handle quotation marks and apostrophes in ‘sgml-quote


From: Michał Nazarewicz
Subject: bug#31006: [PATCH] Handle quotation marks and apostrophes in ‘sgml-quote’
Date: Sat, 7 Apr 2018 11:20:27 +0100

2018-04-01 9:59 GMT+01:00 Eli Zaretskii <address@hidden>:
>> From: Michal Nazarewicz <address@hidden>
>> Date: Sat, 31 Mar 2018 18:00:35 +0100
>>
>> To be able to use text in an HTML argument, quotation marks need
>> to be replaced with an appropriate character reference.  Make
>> ‘sgml-quote’ do that.
>>
>> While at it, fix entiteis not being unquoted if they lack closing
>> semicolon (e.g. ‘&amp’) occuring at the very end of a region.
>> Even though unlikely, make ‘sgml-quote’ handle this scenario.
>>
>> * lisp/textmodes/sgml-mode.el (sgml-quote): Handle quotation marks and
>> apostrophes.  Match entities lacking semicolon at the end of regions.
>> * test/lisp/textmodes/sgml-mode-tests.el (sgml-quote-works): New test
>> case for ‘sgml-quote’ function.
>
> Thanks, this LGTM, with a minor nit: the NEWS entry should be marked
> "---", as sgml-quote is not currently documented in the Emacs manual.

Done.

> Please wait for a few days to let others comment, and if nothing else
> comes up, please push to the master branch with the above nit fixed.

Pushed.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]