bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25717: 25.1.1; "erc-button-google-url" should not refer to a specifi


From: Romanos Skiadas
Subject: bug#25717: 25.1.1; "erc-button-google-url" should not refer to a specific search engine
Date: Sat, 14 Apr 2018 19:41:20 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0



On 14/04/18 19:32, Lars Ingebrigtsen wrote:
Andrew Robbins <address@hidden> writes:

The ERC variable "erc-button-google-url" should not refer to a
specific search engine in its name and certainly not a
privacy-disrespecting one at that in a GNU program[1].

I would suggest renaming the variable to something more generic
such as "erc-button-web-search-url" or "erc-button-search-url"
and changing the default value from
"http://www.google.com/search?q=%s" to any of the following (or
similar) at the developers' preference:

* "http://duckduckgo.com/?q=%s"
This is now fixed in Emacs 27.1.

Looks like the docstring needs to change as well (emphasis mine):
-(defcustom·erc-button-google-url "http://www.google.com/search?q=%s"
+(defcustom·erc-button-search-url "http://duckduckgo.com/?q=%s"
· "URL used to browse Google search references.
%s·is replaced by the search string."
+· :version "27.1"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]