[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in
From: |
Noam Postavsky |
Subject: |
bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 |
Date: |
Sat, 09 Jun 2018 08:13:03 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
>> The `(aref element 0)` trick is the only one that `soap-client` uses. All
>> other struct usage is via accessor functions, the rest of the code does not
>> assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is
>> not needed.
> I went back and tested with cl-old-struct-compat-mode disabled, with the
> soap-type-of patch, and I get an earlier failure, via M-x excorporate:
> So at least for Excorporate, cl-old-struct-compat-mode is
> needed (in addition to the (aref ... 0) -> (soap-type-of ...)
> soap-client change).
Yeah, and for (type-of element) to properly substitute for (aref element
0) without cl-old-struct-compat-mode you would need
(defun soap-type-of (element)
"Return the type of ELEMENT."
(let ((type (type-of element)))
(unless (eq type 'vector) ; For Emacs 25 and earlier.
(setq type (aref element 0)))
(if (string-match "\\`cl-struct-" (symbol-name type)) ; Old-style struct.
(intern (substring (symbol-name type) (match-end 0)))
type)))
But since cl-old-struct-compat-mode activates automagically, may as well
take advantage of it.
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, (continued)
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Alex Harsanyi, 2018/06/16
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/16
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Alex Harsanyi, 2018/06/16
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Noam Postavsky, 2018/06/16
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/17
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/09
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1,
Noam Postavsky <=