bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should res


From: João Távora
Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate
Date: Sat, 23 Jun 2018 17:22:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Hi,

If the Emacs client was started without an explicit list of buffers to
edit, save-some-buffers is called with t for PRED (save all buffers),
but that was before save-some-buffers-default-predicate existed.

I don't see any reason why save-some-buffers-default-predicate shouldn't
be respected in server-save-buffers-kill-terminal (of course if ARG is
non-nil, we do pass t so that the previous behaviour remains).

Trivial patch attached,
João

diff --git a/lisp/server.el b/lisp/server.el
index ff03cbe622..ac14ef314e 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1670,9 +1670,9 @@ server-save-buffers-kill-terminal
             ;; and offer to save all buffers.  Otherwise, offer to
             ;; save only the buffers belonging to the client.
             (save-some-buffers
-             arg (if buffers
-                     (lambda () (memq (current-buffer) buffers))
-                   t))
+             arg (and buffers
+                      (lambda () (memq (current-buffer) buffers))
+                       (and arg t)))
             (server-delete-client proc)))
          (t (error "Invalid client frame")))))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]