[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32372: [PATCH] Add "uuid" to thing-at-point.el
From: |
Raimon Grau |
Subject: |
bug#32372: [PATCH] Add "uuid" to thing-at-point.el |
Date: |
Thu, 09 Aug 2018 19:50:07 +0100 |
Ivan Shmakov <ivan@siamics.net> writes:
> While either ‘and’ or ‘if’ can be used here, to exactly the same
> effect, the indentation above is one for ‘if’; ‘and’ should instead
> look like:
>
> (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
> (cons (match-beginning 0) (match-end 0)))
>
> I think in this case it’s marginally better to keep indentation
> and replace ‘and’ with ‘if’ than the other way around.
What about `when'? Is it ok to use it?
One branch 'if' look funny to me but I don't see many (any?) `when' in the emacs
codebase.
Thanks,
Raimon Grau
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, (continued)
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/05
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Noam Postavsky, 2018/08/05
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Basil L. Contovounesios, 2018/08/06
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/06
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Noam Postavsky, 2018/08/06
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/07
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Ivan Shmakov, 2018/08/07
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Basil L. Contovounesios, 2018/08/07
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/09
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Ivan Shmakov, 2018/08/09
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el,
Raimon Grau <=
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Basil L. Contovounesios, 2018/08/09
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Ivan Shmakov, 2018/08/10
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/11
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Noam Postavsky, 2018/08/13