[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30823: 25.3; modification-hooks of overlays are not run in some case
From: |
Stefan Monnier |
Subject: |
bug#30823: 25.3; modification-hooks of overlays are not run in some cases |
Date: |
Sun, 19 Aug 2018 16:46:09 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
>> Coming back to this, there is also the possibility of passing true for
>> PREPARE, though I'm not sure if that would be better or worse. Any
>> comments?
> AFAIR, we never want to use PREPARE = true when dealing with the
> *Messages* buffer, you can see that elsewhere in message_dolog. The
> reason I believe is that we might trigger infinite recursion if the
> modification hooks log a message for some reason.
The current code already allows running `message` in this way (and that
leads to suboptimal behavior, tho nothing really serious). I think we
should use `true` here and then actively try and detect nested uses of
`message` and deal with those in an ad-hoc way (e.g. bind
inhibit-modification-hooks during the nested call so the recursion is at
most 2 deep).
The benefit is that it makes this part of the code more "normal" and
will probably fix/avoid other bugs like this one.
The patch I sent in
https://lists.gnu.org/archive/html/emacs-devel/2018-05/msg00600.html
went in this direction and my experimentation with it did not encounter
any serious problem. IOW I think the comment near message_dolog is
largely out of date.
Stefan
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Noam Postavsky, 2018/08/17
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Eli Zaretskii, 2018/08/18
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Stefan Monnier, 2018/08/18
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Eli Zaretskii, 2018/08/19
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Stefan Monnier, 2018/08/19
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Eli Zaretskii, 2018/08/19
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Richard Stallman, 2018/08/19
- bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Eli Zaretskii, 2018/08/20
bug#30823: 25.3; modification-hooks of overlays are not run in some cases,
Stefan Monnier <=
bug#30823: 25.3; modification-hooks of overlays are not run in some cases, Noam Postavsky, 2018/08/23