bug#32628: 26; Rename `window-setup-hook'

[Drew Adams]

> >> maybe a better rename for window-setup-hook would be after-init-frames-hook
> >> or even after-frames-setup-hook
> >
> > The frame settings involved are user settings; it's not about the init 
> > frame without user settings. The latter name is OK: after-frames-setup-hook.
> 
> Actually the prefix after- implies there is its counterpart before- 

I don't think it does.

> like in before-init-hook and after-init-hook. 

The existence of some such pairs doesn't at all suggest, let alone
imply, that either before or after must be paired with the other.

The point of before and after is to signify occurrence relative to
some other action/time.

There is after-change-major-mode-hook. No such before hook.
There is after-setting-font-mode-hook. No such before hook.
There is bookmark-after-jump-hook. No such before hook.
There is change-major-mode-after-body-hook. No such before hook.
There is dframe-after-select-attached-frame-hook. No such before hook.
There is ediff-after-quit-hook-internal. No such before hook. 
There is find-function-after-hook. No such before hook.
There is imenu-after-jump-hook. No such before hook.
There is input-method-after-insert-chunk-hook. No such before hook.
There is rmail-after-get-new-mail-hook. No such before hook.
There is speedbar-after-create-hook. No such before hook.

There is before-hack-local-variables-hook. No such after hook.
There is before-make-frame -hook. No such after hook.
There is ediff-before-setup-hook. No such after hook. 
There is speedbar-before-delete-hook. No such after hook. 
There is speedbar-before- popup-hook. No such after hook.
There is speedbar-before-visiting-file-hook. No such after hook.
There is speedbar-before-visiting-tag-hook. No such after hook.
There is vc-before-checkin-hook. No such after hook.

> So we don't need the prefix after-,

I think we do. Or rather, I think it helps.

> that leaves just frames-setup-hook.  Is it better than window-setup-hook?

I prefer after-frames-setup-hook. But I've already said that I'm probably OK 
with whatever you decide. I'm OK with it.