[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32637: 27.0.50; window-size-change-functions not run from local hook
From: |
Juri Linkov |
Subject: |
bug#32637: 27.0.50; window-size-change-functions not run from local hook |
Date: |
Sun, 09 Sep 2018 19:17:27 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
>> window-size-change-functions calling code could detect if a window with
>> a buffer-local hook changed its size, and not to call its hook in this
>> case. This would be even better than using global hook where you can't
>> implement such optimization.
>
> Agreed.
>
>> window-size-change-functions calling code could call it only once
>> for every frame, even if the same buffer is displayed in multiple
>> windows.
>
> Agreed.
>
>> I see that it's not called when the buffer is not displayed in any
>> window on the frame - this is correct. But what I noted earlier is that
>> it's not called when the buffer with the buffer-local hook is not the
>> current-buffer in the selected window (but it's displayed in a
>> non-selected window on the frame) - this should be fixed to call the hook
>> regardless if its window is currently selected or not.
>
> Agreed. I attach an untested and undocumented patch. Please have a
> look.
Thank you for the patch. I tried it and it works without problems.
I'm testing it on the image window resizing in bug#32672
and it calls window-size-change-functions regardless if the current
buffer is in image-mode, or if the image buffer in another window.
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, (continued)
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, Juri Linkov, 2018/09/05
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, martin rudalics, 2018/09/06
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, Juri Linkov, 2018/09/06
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, martin rudalics, 2018/09/07
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, Juri Linkov, 2018/09/08
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, Eli Zaretskii, 2018/09/09
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, martin rudalics, 2018/09/09
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, Eli Zaretskii, 2018/09/09
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, martin rudalics, 2018/09/10
- bug#32637: 27.0.50; window-size-change-functions not run from local hook,
Juri Linkov <=
- bug#32637: 27.0.50; window-size-change-functions not run from local hook, martin rudalics, 2018/09/10