Eli Zaretskii <
eliz@gnu.org> schrieb am Fr., 21. Sep. 2018 um 15:46 Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 21 Sep 2018 15:27:48 +0200
> Cc: Philipp Stephani <phst@google.com>
>
> + $(MKDIR_P) -m 0755 $(includedir)
> + $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h
Thanks. I wonder whether we should install in $(includedir)/emacs.
It sounds rude to me to invade the top-level include directory; other
packages install into package-specific subdirectories.
I think it's not necessary to include "emacs" twice in the file name: using "emacs-module.h" should already be unique enough, and including "emacs" twice doesn't make it more unique.
If you agree, we may need to change mod-test.c and perhaps also the
place where we keep emacs-module.h in the Emacs tree.
We should also think what will happen when we change the interface in
some backward-incompatible way: how do we allow end-users to compile
modules for several Emacs versions on the same system? does that
require a new version of the header, or can we provide a header that
will work with any Emacs version?
I don't think we can ever have backward-incompatible changes: only additions are possible. This isn't different from other headers. That is, the header for version N should also work for all versions older than N.