[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32991: 27.0.50; diff-auto-refine-mode a no-op
From: |
Stefan Monnier |
Subject: |
bug#32991: 27.0.50; diff-auto-refine-mode a no-op |
Date: |
Tue, 09 Oct 2018 15:54:55 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
>> >> * lisp/vc/diff-mode.el: Perform hunk refinement from font-lock
>> > Looks like this commit makes diff-auto-refine-mode a no-op, since
>> > hunks are now always refined. Is that the intention?
>> Yes. Of course, it depends on the value of diff-font-lock-refine.
> Ok. In that case, do we still need diff-auto-refine-mode?
It should probably be merged with diff-font-lock-refine (e.g. have
3 possible values).
>> > Also, with automatic refinement always on, does the following part of
>> > diff-mode.el still require refining the hunk?
>> I believe this is the same question.
> I'm not sure I understand.
I'm saying that this is the same question as that discussed in the
previous paragraph: one looks at the config var, and the other looks at
the code implementing the functionality related to the config var, but
the two are inextricably linked.
Stefan