bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap'


From: Eli Zaretskii
Subject: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap'
Date: Fri, 25 Jan 2019 10:50:29 +0200

> From: Alex Branham <address@hidden>
> Cc: Eli Zaretskii <address@hidden>, address@hidden
> Date: Mon, 21 Jan 2019 09:53:29 -0600
> 
> 
> On Sat 19 Jan 2019 at 09:33, Stefan Monnier <address@hidden> wrote:
> 
> >>>  (defvar tabulated-list-mode-map
> >>> -  (let ((map (copy-keymap special-mode-map)))
> >>> +  (let ((map (make-sparse-keymap)))
> >>>      (set-keymap-parent map button-buffer-map)
> >
> > Nowadays we can inherit from both with something like
> >
> >     (set-keymap-parent map (make-composed-keymap
> >                             button-buffer-map
> >                             special-mode-map))
> 
> Thanks, that's better! Here's the updated patch.

Thanks, pushed to the master branch.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]