bug detected in rtapelib

[Frank Mayer]

Hi people,

I think I've happened across a bug in the rtapelib handling of the
remote_shell:

On Lines 417-421 of rtapelib.c, the code reads
<code>
    remote_shell_basename = base_name (remote_shell);
    if (remote_shell_basename)
      remote_shell_basename++;
    else
      remote_shell_basename = remote_shell;
<code>

If "base_name" happens to be broken (producing e.g. "/rsh" from
"/usr/bin/rsh"), this will work ok,
but whenever "base_name" produces the correct base name, executing the
remote shell will fail 
(at least does so on AIX 4.3).

I think the correct code would read like
<code>
  if (remote_shell_basename && *remote_shell_basename=='/')
<code>
        ...
I hope I'm not mistaken, and this report will help.


Best wishes,
  Frank
---
Frank Mayer
Unix Systemadministration

KNAPP Systemintegration GmbH
Waltenbachstrasse 9
A-8700 Leoben, Austria

Phone:   +43 3842 805-910
E-Mail:    address@hidden