Re: internal error: aborting at ldlang.c line 3843 in lang_place_orphans

[Alan Modra]

On Mon, Oct 14, 2002 at 05:23:59AM +0200, Christian Biere wrote:
> don't ask me what I was trying to do but ld told me I should report this:

Don't ask me why I put the abort in either.  ;)

> ld: internal error: aborting at ldlang.c line 3843 in lang_place_orphans

Applying.

        * ldlang.c (lang_place_orphans): Don't abort on just_syms_flag.
        (lang_reasonable_defaults): Don't compare against false.
        (size_input_section): Likewise.
        (lang_size_sections_1): Likewise.
        (lang_do_assignments): Likewise.
        (lang_add_output): Likewise.

Index: ld/ldlang.c
===================================================================
RCS file: /cvs/src/src/ld/ldlang.c,v
retrieving revision 1.100
diff -u -p -r1.100 ldlang.c
--- ld/ldlang.c 10 Oct 2002 15:59:10 -0000      1.100
+++ ld/ldlang.c 14 Oct 2002 12:32:40 -0000
@@ -2022,7 +2022,7 @@ lang_reasonable_defaults ()
 
   default_common_section = lang_output_section_statement_lookup (".bss");
 
-  if (placed_commons == false)
+  if (!placed_commons)
     {
       lang_wild_statement_type *new =
       new_stat (lang_wild_statement,
@@ -2778,7 +2778,7 @@ size_input_section (this_ptr, output_sec
   lang_input_section_type *is = &((*this_ptr)->input_section);
   asection *i = is->section;
 
-  if (is->ifile->just_syms_flag == false)
+  if (!is->ifile->just_syms_flag)
     {
       unsigned opb = bfd_arch_mach_octets_per_byte (ldfile_output_architecture,
                                                    ldfile_output_machine);
@@ -3033,11 +3033,10 @@ lang_size_sections_1 (s, output_section_
                                       abs_output_section,
                                       lang_allocating_phase_enum,
                                       dot, &dot);
-                   if (r.valid_p == false)
-                     {
-                       einfo (_("%F%S: non constant address expression for 
section %s\n"),
-                              os->name);
-                     }
+                   if (!r.valid_p)
+                     einfo (_("%F%S: non constant address expression for 
section %s\n"),
+                            os->name);
+
                    dot = r.value + r.section->bfd_section->vma;
                  }
 
@@ -3404,7 +3403,7 @@ lang_do_assignments (s, output_section_s
                                   abs_output_section,
                                   lang_final_phase_enum, dot, &dot);
            s->data_statement.value = value.value;
-           if (value.valid_p == false)
+           if (!value.valid_p)
              einfo (_("%F%P: invalid data statement\n"));
          }
          {
@@ -3441,7 +3440,7 @@ lang_do_assignments (s, output_section_s
                                   abs_output_section,
                                   lang_final_phase_enum, dot, &dot);
            s->reloc_statement.addend_value = value.value;
-           if (value.valid_p == false)
+           if (!value.valid_p)
              einfo (_("%F%P: invalid reloc statement\n"));
          }
          dot += bfd_get_reloc_size (s->reloc_statement.howto) / opb;
@@ -3848,9 +3847,7 @@ lang_place_orphans ()
                 around for a sensible place for it to go.  */
 
              if (file->just_syms_flag)
-               {
-                 abort ();
-               }
+               ;
              else if (strcmp (s->name, "COMMON") == 0)
                {
                  /* This is a lonely common section which must have
@@ -4024,7 +4021,7 @@ lang_add_output (name, from_script)
      int from_script;
 {
   /* Make -o on command line override OUTPUT in script.  */
-  if (had_output_filename == false || !from_script)
+  if (!had_output_filename || !from_script)
     {
       output_filename = name;
       had_output_filename = true;

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre