intl/Makefile po/Makefile bug

[Andrew Clausen]

Hi all,

This Makefile code is problematic:

          for file in $$dists; do \
            if test -f $$file; then dir=.; else dir=$(srcdir); fi; \
            $(INSTALL_DATA) $$dir/$$file \
                            $(DESTDIR)$(gettextsrcdir)/$$file; \
          done; \

It appears many times in po/Makefile and intl/Makefile.
Anyway, it breaks if $$file contains an absolute path.  You get:
".//the/path" which doesn't resolve properly.

$$file may be an absolute path if you use gettext in another program,
and have your build and source directories separate.

I suggest, the following replacement code:

          for file in $$dists; do \
            if test -f $$file; then dir=; else dir=$(srcdir)/; fi; \
            $(INSTALL_DATA) $$dir$$file \
                            $(DESTDIR)$(gettextsrcdir)/$$file; \
          done; \

This code seems to be the same in 0.10.40 and 0.11.5.

BTW: which version is recommended for stable branches of free softare
projects?

Cheers,
Andrew