objcopy.c: question regarding debugging info handling

[Joerg Wunsch]

Hello,

i'm currently considering to add the ability of handling COFF
debugging symbols to objcopy (namely to write AVR COFF as used by the
Atmel tools, which uses native COFF debug symbols).  I'm wondering
about the following piece in objcopy.c::filter_symbols():

      else if ((flags & BSF_DEBUGGING) != 0)    /* Debugging symbol.  */
        keep = (strip_symbols != STRIP_DEBUG
                && strip_symbols != STRIP_UNNEEDED
                && ! convert_debugging);

This will make a symbol from the symtab go away that is marked as
BSF_DEBUGGING even though convert_debugging is true.  Shouldn't that
be

        keep = (strip_symbols != STRIP_DEBUG
                && strip_symbols != STRIP_UNNEEDED)
               || convert_debugging;

instead, i. e. when convert_debugging is true, BSF_DEBUGGING symbols
should always be kept?  (Of course, it would better be reordered so
convert_debugging is evaluated first.)

-- 
J"org Wunsch                                           Unix support engineer
address@hidden        http://www.interface-systems.de/~j/