Re: [Mingw-users] Re: More patch 2.5.9 hacking

[Earnie Boyd]

Eli Zaretskii wrote:
> > From: Paul Eggert <address@hidden>
> > Date: 22 Oct 2003 09:19:57 -0700
> >
> > My own feeling is that the mainline code shouldn't have to worry about
> > CRLF issues; it should just use '\n'.
>
>
> Text-mode I/O, which is the default in the DJGPP port, achieves
> precisely that.

I agree in heart but enjoy the freedom of not having to defend the position.

> > In general, people should import files
> > correctly rather than modify all their tools to deal with bad files.
>
>
> I agree with the goal, but my experience has taught me that in
> practice it is very hard to achieve that.  So if we have an easy way
> to deal with that nuisance without adding too much cruft to the
> mainline code, our users will thank us.

I think that could be achieved.  The main problems reside with a \n file 
with a \r\n patchfile and vice versa.  So on a DOSISH_FILE_SYSTEM check 
for \r at the end of the string and replace it with \0 for both reads.

If --binary is given then the output file is also opened in binary mode.

Earnie
--
http://www.mingw.org
Powered by SourceForge <http://sourceforge.net/projects/mingw>