[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Questions about patch

From: Eli Zaretskii
Subject: Re: Questions about patch
Date: Tue, 05 Apr 2005 22:16:40 +0300

> From: "Gary Setter" <address@hidden>
> Cc: <address@hidden>,
>       <address@hidden>
> Date: Tue, 5 Apr 2005 08:17:42 -0500
> Is the binary switch a good design? It seems to me that
> consistently reading files as binary would be better. If the user
> is not all knowing (and I'm not) he can easily get himself in
> trouble.

A user who doesn't know better should not use --binary.  Without that
switch, Patch can read original and patch files of both Unix and DOS
format, including the case that one of them is Unix while the other
DOS, and will produce patched files in the DOS format.  That is good
enough for DOS/Windows platforms.

> Some versions of seek would hang if the file was not
> opened as binary.

Such fseek is broken, and should be replaced.  I wasn't talking about
such cases.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]