Re: patch to fix build warning for gettext-0.14.4

[Bruno Haible]

Jeff Rizzo wrote:
> When building gettext-0.14.4 for NetBSD/macppc, the following warning
> happens:
>
> /home/riz/tools-current/bin/powerpc--netbsd-gcc -O2 -pipe  -Werror  -pipe  
> -DHAVE_CONFIG_H -I/usr/src-current/gnu/usr.bin/gettext/libnlspr
> -I/usr/src-current/gnu/usr.bin/gettext/libnlspr/../include 
> -I/usr/src-current/gnu/dist/gettext/gettext-tools/lib
> -DLOCALEDIR=\"/usr/share/locale\"
> -I/usr/src-current/gnu/dist/gettext/gettext-runtime/intl
> -DLIBDIR=\"/home/riz/buildobj-current/usr/src-current/destdir.macppc/usr/share\"
> -DGETTEXTJAR=\"/home/riz/buildobj-current/usr/src-current/destdir.macppc/usr/share/gettext/gettext.jar\"
> -DGETTEXTDATADIR=\"/home/riz/buildobj-current/usr/src-current/destdir.macppc/usr/share/gettext\"
>  -DHAVE_CONFIG_H
> -I/usr/src-current/gnu/usr.bin/gettext/libnlspr
> -I/usr/src-current/gnu/usr.bin/gettext/libnlspr/../include 
> -I/usr/src-current/gnu/dist/gettext/gettext-tools/lib
> -DLOCALEDIR=\"/usr/share/locale\"   -nostdinc -isystem
> /home/riz/buildobj-current/usr/src-current/destdir.macppc/usr/include -c   
> /usr/src-current/gnu/dist/gettext/gettext-tools/src/po-lex.c -o
> po-lex.o.tmp /usr/src-current/gnu/dist/gettext/gettext-tools/src/po-lex.c:
> In function `mb_width':
> /usr/src-current/gnu/dist/gettext/gettext-tools/src/po-lex.c:313: warning:
> comparison is always true due to limited range of data type
>
>
> The following patch silences this warning

Thanks for the report and patch. But your patch introduces ugly #ifs
in the code, and makes the code more brittle. I prefer the existing code
because it is more robust, even if it elicits (benign) warnings on some
platforms.

Bruno