Re: address@hidden: [PATCH] sharutils-4.3.80: configure.ac tweak to build uuencode/uudecode OOTB on Cygwin]

[Corinna Vinschen]

On Jun  7 21:21, Bob Proulx wrote:
> Bruce Korb wrote:
> > Thank you for the patch.  I have applied it, substituting
> > '{' for '(' and '}' for ')'.  Next release (not too far away,
> 
> Shouldn't Makefile variables use the smooth parenthesis, not the curly
> ones like the shell?  I believe GNU make allows either.  But that is
> not true of all make programs.  The V7 make documentation only
> specifies $(string).  POSIX requires both.  All of the examples for
> GNU make and GNU autoconf that I can find suggest $(string).
> 
> > > -  ADD_PROG="uudecode uuencode"
> > > +  ADD_PROG='uudecode$(EXEEXT) uuencode$(EXEEXT)'
> > > -  ADD_PROG="uudecode uuencode"
> > > +  ADD_PROG='uudecode$(EXEEXT) uuencode$(EXEEXT)'
> 
> If those end up in a Makefile aren't the $(EXEEXT) usage correct?

Thanks for applying, Bruce.  But yes, parenthesis should be more correct
than curly brackets.  It's the same syntax also used by automake when
creating Makefile.in.

src/Makefile.am:

  bin_PROGRAMS = shar unshar @ADD_PROG@

src/Makefile.in:

  bin_PROGRAMS = shar$(EXEEXT) unshar$(EXEEXT) @ADD_PROG@


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.