bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gawk: length return incorrect value when MB_CUR_MAX > 1


From: Aharon Robbins
Subject: Re: gawk: length return incorrect value when MB_CUR_MAX > 1
Date: Thu, 01 Dec 2005 08:32:13 +0200

Kimura,

It sounds like you prefer Paul's patch?  I guess a valid question is:

> I found mbrtowc() store L'\0' to &wc when detect '\0'.

Is this portable behavior? I.e., defined by the ISO C standard?

In any case, I'll apply one patch or the other; Paul's looks preferable
if it's the most portable.

Thanks!

Arnold

> Date: Thu, 01 Dec 2005 13:33:27 +0900
> From: KIMURA Koichi <address@hidden>
> Subject: Re: gawk: length return incorrect value when MB_CUR_MAX > 1
> To: Paul Eggert <address@hidden>
> Cc: Hirofumi Saito <address@hidden>, address@hidden
>
> Hi,
>
>
> On Wed, 30 Nov 2005 13:39:56 -0800
> Paul Eggert <address@hidden> wrote:
>
> > Yes, his patch should work.
> > 
> > Here's a slightly more-efficient patch:
> > 
> > --- node.c-bak      2005-07-26 11:07:43.000000000 -0700
> > +++ node.c  2005-11-30 13:33:44.000000000 -0800
> > @@ -749,9 +749,10 @@ str2wstr(NODE *n, size_t **ptr)
> >             switch (count) {
> >             case (size_t) -2:
> >             case (size_t) -1:
> > -           case 0:
> >                     goto done;
> >  
> > +           case 0:
> > +                   count = 1;
> >             default:
> >                     *wsp++ = wc;
> >                     src_count -= count;
>
> Thank you for correct me.
> I found mbrtowc() store L'\0' to &wc when detect '\0'.
>
> -- 
> KIMURA Koichi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]