bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gawk: setting BINMODE on command line produces bogus error


From: Aharon Robbins
Subject: gawk: setting BINMODE on command line produces bogus error
Date: Wed, 14 Dec 2005 19:03:59 +0200

Hello World.

Eli Zaretskii points out to me in private email the following:

$ gawk -v BINMODE=3 'BEGIN { print BINMODE }'
gawk: warning: BINMODE: arbitrary string value treated as "rw"
3

Patch below.

Arnold Robbins
------------------------------------------
Wed Dec 14 18:57:34 2005  Arnold D. Robbins  <address@hidden>

        * eval.c (set_BINMODE): Fix logic of test for no numeric value.
        Makes `gawk -v BINMODE=1 ...' work again. Thanks to Eli Zaretskii
        <address@hidden> for pointing out the problem.


--- ../gawk-3.1.5/eval.c        2005-07-26 21:07:43.000000000 +0300
+++ eval.c      2005-12-14 18:57:26.786298398 +0200
@@ -2167,7 +2167,7 @@
                        }
                }
 
-               if (! digits || (BINMODE_node->var_value->flags & MAYBE_NUM) == 
0) {
+               if (! digits && (BINMODE_node->var_value->flags & MAYBE_NUM) == 
0) {
                        BINMODE = 0;
                        if (strcmp(p, "r") == 0)
                                BINMODE = 1;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]