Re: Solaris, GCC and libintl

[Bruno Haible]

Hello,

Eric Botcazou wrote:
> We have a problem in GCC on SPARC/Solaris 64-bit with the version of libintl 
> present in the GNU toolchain tree (http://gcc.gnu.org/23541).

You mean http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23541, I assume.
And also http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24039

> My understanding is that the gettext build system is clever enough to 
> overcome 
> this kind of problems (I didn't manage to reproduce the problem there) but we 
> use a custom, stripped-down build system in the GCC tree.  As a result, there 
> is an ordering constraint on the inclusion of <locale.h> and "libintl.h" on 
> Solaris, namely the former must be included after the latter.
> ...
> Would you be OK to apply it to the pristine gettext sources?

You have a funny logic. You note that the problem is not reproducible
in gettext itself, and conjecture that it is due to gcc's own build
infrastructure of the intl/ directory - which I'm tempted to conjecture
too, after a look at [1] - and then you propose to change the original
gettext!

The right question to ask in this situation is: what the particular
difference between the gettext build infrastructure and the gcc build
infrastructure that makes it work inside gettext and not inside gcc?

The answer is that gcc's copy is based on gettext-0.12.1 whereas gettext
has this in the ChangeLog:

2003-09-04  Bruno Haible  <address@hidden>

        * dgettext.c: Include <locale.h> after gettextP.h, not before. This
        ensures that libintl_dcgettext is correctly declared on Solaris.
        (Needed because Solaris <locale.h> includes libintl.h.)
        * dngettext.c: Likewise, for the libintl_dcngettext declaration.

All you have to do is to ensure that this patch is applied to the
relevant branches of the gcc repository.

Bruno

[1] http://gcc.gnu.org/viewcvs/trunk/intl/VERSION?revision=68928&view=markup