bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch: do not emit trailing blanks in context header


From: Ralf Wildenhues
Subject: Re: patch: do not emit trailing blanks in context header
Date: Tue, 7 Nov 2006 18:38:54 +0100
User-agent: Mutt/1.5.13 (2006-11-01)

Hello Paul,

* Paul Eggert wrote on Tue, Nov 07, 2006 at 06:28:05PM CET:
> Ralf Wildenhues <address@hidden> writes:
> 
> > AFAICS, Solaris 10 patch is _not_ resilient against missing trailing blanks.
> > (It does have a few other quirks with unified diffs that GNU patch does 
> > not.)
> 
> I vaguely recall having lots of problems with Solaris 'patch', even
> aside from -u.

Yes.  Unidiffs resulting in or starting with a one-line file are not
treated properly.  Unidiffs starting with an empty or non-existent files
are a problem.  -o is not treated in accordance with POSIX (.orig files
may end up next to the files that are read).  diffs changing multiple
files need `Index:' lines or other measures to keep 'patch' from asking
interactive questions...

> > (Simply ignoring lines matching '^[\t ]*- $' would probably be
> > enough for all practical purposes.)
> 
> Sorry, I don't follow this point.  The lines in question contain a
> single space, and that doesn't match the pattern you give.

Ouch.  Thinko of mine, sorry about that.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]