Re: diffutils release imminent

[Jim Meyering]

Andreas Schwab wrote:

> Mike Frysinger <address@hidden> writes:
>
>> On Friday 05 February 2010 06:30:47 Jim Meyering wrote:
>>> Mike Frysinger wrote:
>>> > Fedora also seems to have a trivial typo patch you'll probably want to
>>> > integrate:
>>> > --- diffutils-2.8.1/src/analyze.c.badc    2004-01-08 10:05:59.094598972
>>> > +0000 +++ diffutils-2.8.1/src/analyze.c   2004-01-08 10:06:22.294841900
>>> > +0000 @@ -983,7 +983,7 @@
>>> >   changes = briefly_report (changes, cmp->file);
>>> >        else
>>> >   {
>>> > -   if (changes | !no_diff_means_no_output)
>>> > +   if (changes || !no_diff_means_no_output)
>>> >       {
>>> >         /* Record info for starting up output,
>>> >            to be used if and when we have some output to print.  */
>>>
>>> Can you point me to an example of how that bug causes
>>> diff to misbehave?  I'd like to add a test for the fix.
>>
>> no idea.  Fedora changelog only says:
>> * Thu Jan  8 2004 Tim Waugh <address@hidden> 2.8.1-10
>> - Fix mistaken use of '|' instead of '||'.
>
> Since changes can only be 0 or 1 at this point this does not make a
> difference.

Thanks.  Confirmed.
We've made a few changes like that in coreutils recently.
They were solely for the sake of readability/maintainability,
so one doesn't have to worry about "what if the value is not 0/1?".

I'll do the same in this case.