[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Link libgettextpo with libunistring
From: |
Bruno Haible |
Subject: |
Re: [PATCH] Link libgettextpo with libunistring |
Date: |
Sun, 6 Jun 2010 20:14:01 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Dmitry,
Dmitry V. Levin wrote:
> diff --git a/gettext-tools/libgettextpo/Makefile.am
> b/gettext-tools/libgettextpo/Makefile.am
> index 6ea1d5b..b739e9f 100644
> --- a/gettext-tools/libgettextpo/Makefile.am
> +++ b/gettext-tools/libgettextpo/Makefile.am
> @@ -98,7 +98,7 @@ LTV_AGE=5
> # How to build libgettextpo.la.
> # Don't make it depend on libgettextsrc.la or libgettextlib.la, since they
> # define an uncontrolled amount of symbols.
> -libgettextpo_la_LIBADD = libgnu.la $(WOE32_LIBADD)
> +libgettextpo_la_LIBADD = libgnu.la $(LTLIBUNISTRING) $(WOE32_LIBADD)
> libgettextpo_la_LDFLAGS = \
> -version-info $(LTV_CURRENT):$(LTV_REVISION):$(LTV_AGE) \
> -rpath $(libdir) \
You're absolutely right. I'm applying the equivalent patch below, and am
releasing gettext-0.18.1.1 for this fix. I'll also add a unit test that
will avoid this mistake for the future.
Thanks!
Bruno
2010-06-06 Bruno Haible <address@hidden>
Avoid link error in programs that use libgettextpo.
* Makefile.am (libgettextpo_la_LIBADD): Add $(LTLIBUNISTRING).
Reported by Dmitry V. Levin <address@hidden>.
--- gettext-tools/libgettextpo/Makefile.am.orig Sun Jun 6 19:58:27 2010
+++ gettext-tools/libgettextpo/Makefile.am Sun Jun 6 19:55:59 2010
@@ -98,7 +98,7 @@
# How to build libgettextpo.la.
# Don't make it depend on libgettextsrc.la or libgettextlib.la, since they
# define an uncontrolled amount of symbols.
-libgettextpo_la_LIBADD = libgnu.la $(WOE32_LIBADD)
+libgettextpo_la_LIBADD = libgnu.la $(WOE32_LIBADD) $(LTLIBUNISTRING)
libgettextpo_la_LDFLAGS = \
-version-info $(LTV_CURRENT):$(LTV_REVISION):$(LTV_AGE) \
-rpath $(libdir) \