Re: [Bug-gnubg] Imported Jellyfish File Problem (File)

[Øystein O Johansen]

> The correct place to fix it would be in ParseMove(), since
> this would address the same problem in a lot of different
> formats, but it looks like a much harder routine to adapt.

I think I disagree that this should be fixed in ParseMove.
Believe ParseMove does it's job right as it is supposed to.
It is the IsValidMove function that fucks it up! I can see
that this function, IsValidMove, is only called in
ParseMatMove, and not in any of the other game parsing
format routines.

(I agree thet ParseMove looks like it's much harder routine to adapt)

> ParseMatMove () could examine the results from ParseMove()
> and re-build the anMove array if need be, incrementing the
> move count. It has the dice values available, so it should
> be able to check that the moves returned by ParseMove() match.

Sounds to me like a lot of trouble. The could can actually be one,
two, three or four for different reasons, that must be checked as
well.

I suggest:
We remove the call to IsValidMove. (I think it's the only call to
this function in the whole program, so we might also remove the
function itself). ParseMove does it's job great anyway, and if
not I guess some other function will complain.

-Øystein



-------------------------------------------------------------------
The information contained in this message may be CONFIDENTIAL and is
intended for the addressee only. Any unauthorised use, dissemination of the
information or copying of this message is prohibited. If you are not the
addressee, please notify the sender immediately by return e-mail and delete
this message.
Thank you.