Re: [Bug-gnubg] Re: Naw..panic or teach me what I am doing wrong !!

[Joern Thyssen]

On Fri, Jan 10, 2003 at 10:06:29AM +1300, Joseph Heled wrote
> 
> I think I found the bug, but I would like an opinion because I can't 
> believe such a blatant error can exist undetected for so long.
> 
> I think wins are logged to the wrong player in the rollout code, when 
> the game is over.
> 
> line 747 in rollout.c
> 
>       if ( iTurn & 1 ) InvertEvaluationR ( aarOutput[ ici ], pci );
> 
> If I change it to
> 
>       if ( ! (iTurn & 1) ) InvertEvaluationR ( aarOutput[ ici ], pci );
> 
> I start to get exactly my numbers again.

It think it's close enough: actually the bug appears to be that the
evaluation just preceding that is evaluated for the wrong player on
roll --- but your fix is equivalent, as we only end up there if the game
is over, in which case it doesn't matter who's on roll.

Jørn