Re: [Bug-gnubg] winsocket - threads Win32 builds

[Holger]

At 00:06 18.07.2003 +0200, Nardy Pillards wrote:
> From: "Holger" <address@hidden>
> Sent: Thursday, July 17, 2003 10:28 PM
>
>
> > At 03:48 12.07.2003 +0200, Nardy Pillards wrote:
> > >Setting dice to 'random.org' gives:
> > >Fetching 500 random numbers from www.random.org
> > >and next:
> > >www.random.org:80: Invalid argument.
> >
> > Getting the dice from random.org works now on Windows, too. I've also
> > adjusted the other sockets specific functions. However, all this needs
> testing.
> >
> > The above error message unfortunately always appears if there is a socket
> > problem. E.g. in case of a timeout it does, too.
> >
> > Regards,
> >
> >          Holger
>
> Yes, it does work :-) TY.
>
> However: compiling without HAVE_SOCKETS 1 generates link errors from
> gnubg.c.

You need -lwsock32 in Makefile.

> Line 3784 (WSACleanup) and line 7127 (WSAStartup) are socket related.
> Add #if HAVE_SOCKETS ??

I'm not really fond of HAVE_SOCKETS for use on Windows since Winsock is 
after all no full BSD socket replacement. I'd rather introduce a new define 
USE_WINSOCK. 'USE' because every 32bit Windows comes with at least version 
1 of Winsock, thus _has_ it anyway. And because of this imho it's not 
necessary to compile without sockets support. One could remove the 
HAVE_SOCKETS checks for Windows, though.

Regards,

        Holger