[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnubg] Problems with the recent changes regarding sounds
From: |
Jonathan Kinsey |
Subject: |
Re: [Bug-gnubg] Problems with the recent changes regarding sounds |
Date: |
Mon, 04 Dec 2006 13:33:58 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.8) Gecko/20061025 Thunderbird/1.5.0.8 Mnenhy/0.7.4.0 |
Christian Anthon wrote:
> On 12/4/06, Jonathan Kinsey <address@hidden> wrote:
>> More generally I don't like #if blocks - they tend to make the code
>> tricky to maintain (when used excessively). Is there any real overhead
>> of compiling the sound code (and turning the sound off)? Similarly some
>> of the other blocks - time controls for example, could easily be
>> included in all builds?
>>
>
> I agree that the code contains too many #if's. Here the sound code is
> fairly isolated, so blocking everything actually takes fewer #if's.
>
> I wouldn't mind if the sound code was always included, but then we
> should make separate sound options for the cli and the gui.
Exactly - they should have separate options (and defaults). I'm sure
they will at some point in the future...
Jon
signature.asc
Description: OpenPGP digital signature