Re: [Bug-gnubg] GNUbg batch anlaysis not working - BUG/WORKAROUND

[Philippe Michel]

On Sat, 14 May 2011, Michael Petch wrote:

> Okay Guys,
>
> This is rather comical. First the directory name was a red herring - it
> was not the cause (that part works fine). Batch analysis does not work
> properly if you turn off "Luck" analysis (Settings menu/Analysis/"Luck"
> checkbox)!  Leo sent me his gnubautorc file. While doing some testing
> with it I soon discovered that when luck is turned off the Batch
> analysis gets really messed up. Turning it back on seems to resolve the
> issues that Leo is experiencing.
>
> Definitely a bug. I recommend turning Luck analysis on while someone on
> the team can investigate this. I won't have much time on Sunday is
> Philippe wished to look at it (It is probably not a big deal to find and
> fix now).

It looks like the everything has to be analysed (chequer play, cube, luck, 
and for both players) or the partial analysis is deemed "cancelled". This 
check in gtkfile.c:batch_analyse() :

        if (!MatchAnalysed())
        {
                *result = _("Cancelled");
                g_free(save);
                return FALSE;
        }

seems misguided.

There is something similar in relational.c, done in a more considerate 
way :

        /* Warn if match is not finished or fully analyzed */
        if (!quiet && !GameOver())
                strcat(warnings, _("The match is not finished\n"));
        if (!quiet && !MatchAnalysed())
                strcat(warnings, _("All of the match is not analyzed\n"));

        if (*warnings)
        {
                strcat(warnings, _("\nAdd match anyway?"));
                if (!GetInputYN(warnings))
                        return;
        }

but doing something like that in the batch analysis GUI doesn't seem 
straightforward.

Moreover, the hang may be platform- or gtk-version-specific because, on my 
unix system, the "cancelled" matches don't cause problems. The matches are 
not saved (why is obvious from the batch_analyse() code), but there is no 
hang or strange pop-ups.

I suppose removing the if (!MatchAnalysed()) test is a quick way to avoid 
the problem but it is not entirely satisfying, especially if the matches 
are to be added to the database.