Re: [Bug-gnubg] bug: use of uninitialized value at set.c:CommandSetFullScreen

[Michael Petch]

Howdy,

Thanks for the report and patch. I committed it to CVS.

I am curious if it resolved and particular bug? I ask because it happens
to be that there seems to be a screen initialization bug when built on
OS/X where the main window doesn't always get properly drawn when GNUBG
starts. Instead it comes up blank. Resizing it by a tiny bit resolves
the issue.

On 2014-07-12 10:04 PM, Daisuke Takahashi wrote:
> Hi all,
> 
> The valgrind indicates the use of newValue without initialization at the 
> function CommandSetFullScreen. Here is a diff to fix it.
> Thank you very much.
> 
> Regards,
> Daisuke Takahashi
> 
> --- set.orig.c        2014-07-13 12:56:38.000000000 +0900
> +++ set.c     2014-07-13 12:57:34.000000000 +0900
> @@ -429,7 +429,7 @@
>  extern void
>  CommandSetFullScreen(char *sz)
>  {
> -    int newValue;
> +    int newValue = fFullScreen;
>      SetToggle("fullscreen", &newValue, sz, _("Show board in full screen 
> mode"), _("Show board in normal screen mode."));
>  
>      if (newValue != fFullScreen) {      /* Value has changed */
> 
> 
> _______________________________________________
> Bug-gnubg mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/bug-gnubg
> 

-- 
Michael Petch
GNU Backgammon Maintainer / Developer
OpenPGP FingerPrint=D81C 6A0D 987E 7DA5 3219 6715 466A 2ACE 5CAE 3304