[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] addition: pipe.h, pipe-in.c, pipe-out.c, pipe-bidi.c

From: Jim Meyering
Subject: Re: [Bug-gnulib] addition: pipe.h, pipe-in.c, pipe-out.c, pipe-bidi.c
Date: Fri, 30 Jan 2004 12:08:37 +0100

Paul Eggert <address@hidden> wrote:
> Yes, there's probably other junk in gnulib too.  At some point someone
> should do some housecleaning.  Or reorganization.  Or something.
> Gnulib is becoming a bit unwieldy.  (For example, I'd like to put
> almost all the "windows stuff" off into a separate subdirectory so I
> don't have to read it.  :-)

I like the idea of keeping the `windows stuff' separate, but I also
like the idea of encapsulating non-trivial bits of code like that --
especially when one-off implementations often miss subtleties.

However, I must admit that the big, nested #if/else-blocks (some
containing significant chunks of very similar code) do make the code
hard to read.

Bruno, what do you think about separating the code in the .c files
into POSIX/Unix- and Woe-specific parts?

In any case, the nested cpp directives would be easier to read if
they were all indented to reflect the level of nesting.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]