Re: rijndael

[Jim Meyering]

Simon Josefsson <address@hidden> wrote:
> Ok to install?
>
> Comments appreciated, of course.

Hi Simon,

In this function,

+rijndael_rc
+rijndaelMakeKey (rijndaelKeyInstance * key, rijndael_direction direction,
+                int keyLen, char *keyMaterial)

the keyMaterial parameter should be `const'.

And in this one, both key and input be const, too.
There are others like this.

> +int
> +rijndaelPadEncrypt (rijndaelCipherInstance * cipher,
> +                 rijndaelKeyInstance * key, unsigned char *input,
> +                 int inputOctets, unsigned char *outBuffer)