Re: AC_HEADER_STDC

[Bruno Haible]

Paul Eggert wrote:
> memcasecmp.c assumes UCHAR_MAX <= INT_MAX, which is not portable in
> general

Huh? On a system where 'unsigned char' and 'int' have the same number
of bits, the getc() and fgetc() result EOF would be ambiguous: it could
be EOF or it could be a casted 'unsigned char' value. It sounds very
improbable that such a system exists, now or in the future.

>       * m4/getusershell.m4 (gl_PREREQ_GETUSERSHELL): Remove; no longer needed.
>       All uses removed.
>       * m4/strtol.m4 (gl_PREREQ_STRTOL): Likewise.
>       * m4/strtoul.m4 (gl_PREREQ_STRTOUL): Likewise.

I find it more maintainable to keep these macros, even when they are
currently no-ops. Such as in m4/rename.m4. This eases things when some
changes are made later to the lib/*.c file. Not having the distinction
between the macro which tests whether a replacement function is needed
and the macro which prepares for the replacement function itself is
something that was confusing in the beginnings of gnulib, years ago.

Your mileage may vary, of course.

Bruno