[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: iconv modules
From: |
Bruno Haible |
Subject: |
Re: iconv modules |
Date: |
Tue, 5 Sep 2006 14:37:08 +0200 |
User-agent: |
KMail/1.9.1 |
Hi Simon,
> The interface sounds good to me, let's see the code. ;)
I'm making some changes to iconvme::iconv_string on the way of the merge.
I've put them on the 'haible-private' branch of lib/iconvme.c. All based
on code in use in GNU gettext for years. What do you think about them?
Acceptable?
Bruno
revision 1.6.2.7
(iconv_alloc): Realloc the final result, to throw away unused memory.
revision 1.6.2.6
(iconv_alloc): Handle the IRIX iconv behaviour.
revision 1.6.2.5
(iconv_alloc): Call iconv with 2xNULL arguments, also to flush the state
storage.
revision 1.6.2.4
(iconv_alloc): Call iconv with 4xNULL arguments initially, to reset the state.
revision 1.6.2.3
(iconv_alloc): No need to test for " && dest " at the end - dest is
always != NULL there.
revision 1.6.2.2
(iconv_alloc): Don't assume that malloc() or realloc(), when failing, sets
errno to ENOMEM. (malloc on GNU/kFreeBSD doesn't.)
revision 1.6.2.1
(iconv_string): No need to save and restore errno when iconv_alloc succeeded.